[Transform] enhance geobounds test for sparse data case#72023
Merged
hendrikmuhs merged 2 commits intoelastic:masterfrom Apr 22, 2021
Merged
[Transform] enhance geobounds test for sparse data case#72023hendrikmuhs merged 2 commits intoelastic:masterfrom
hendrikmuhs merged 2 commits intoelastic:masterfrom
Conversation
… adding debug logging of index requests send by transform relates elastic#71874
hendrikmuhs
added
>test
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
approved these changes
Apr 22, 2021
przemekwitek
left a comment
przemekwitek
left a comment
There was a problem hiding this comment.
LGTM
but there is a CI failure related to the modified test that needs to be fixed.
Author
|
@elasticmachine update branch |
Author
I changed the test without the fix. The fix (a regression) is done in #71999 and wasn't merged when I opened the PR. Now after updating the branch with the fix, CI is happy. FYI: @wwang500 we have a test now in the backend. |
hendrikmuhs
pushed a commit
that referenced
this pull request
Apr 22, 2021
use sparse data for geobounds agg, verifies the fix of #71874, adding debug logging of index requests send by transform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use sparse data for geobounds agg, verifies the fix of #71874, adding debug
logging of index requests send by transform
relates #71874
If everything works the right way, this change should fail, but start working once rebased using #71999